Skip to content

feat(api): add ton-validators-rewards-api#1978

Draft
delovoyhomie wants to merge 2 commits intomainfrom
validator-rewards-API
Draft

feat(api): add ton-validators-rewards-api#1978
delovoyhomie wants to merge 2 commits intomainfrom
validator-rewards-API

Conversation

@delovoyhomie
Copy link
Contributor

Closes #1917

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update to contract-dev/privacy-zk/groth16-examples.mdx: there’s one inline suggestion—please apply it to align the frontmatter with the supported metadata keys.

Comment on lines +1 to +5
---
title: "Verify Groth16 examples on TON"
sidebarTitle: "Groth16 examples"
description: "Run Groth16 verifier examples on TON with Circom, Noname, Gnark, and Arkworks."
doc_type: "How-to guide"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[HIGH] Disallowed doc_type frontmatter key

The frontmatter introduces a custom doc_type key with value "How-to guide". The style guide forbids adding custom frontmatter keys for internal taxonomy such as document type, requiring this information to live in the page structure or navigation instead. Keeping doc_type in frontmatter violates the supported metadata contract and can break or confuse tooling and contributors that expect only approved keys. This issue arises from the newly added frontmatter in this PR.

Suggested change
---
title: "Verify Groth16 examples on TON"
sidebarTitle: "Groth16 examples"
description: "Run Groth16 verifier examples on TON with Circom, Noname, Gnark, and Arkworks."
doc_type: "How-to guide"
---
title: "Verify Groth16 examples on TON"
sidebarTitle: "Groth16 examples"
description: "Run Groth16 verifier examples on TON with Circom, Noname, Gnark, and Arkworks."
---

Please leave a reaction 👍/👎 to this suggestion to improve future reviews for everyone!

@aigerimu
Copy link
Contributor

  • Let’s keep only the files that are relevant to this PR.
  • "Validator Rewards" is a common term here, so let’s use lowercase - "validator rewards".
  • For consistency, let’s stick to Next steps and See also instead of Related pages.
  • Why is the "Validator rewards API reference" page set to wide mode?
  • What is the ton-validators-rewards-api file?

reward and staking data directly from TON liteservers through `tongo`.

<Aside type="note">
The source does not define a public hosted base URL. The examples in this
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which examples?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which examples?

@aigerimu aigerimu marked this pull request as draft March 20, 2026 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Ecosystem > APIs > Validator Rewards API]

3 participants