Ignore Set-Cookie header from Commons in worker#358
Merged
Conversation
A configuration changed introduced in T417833 results in cookies being saved in our workers. This breaks session isolation since we don't clear cookies when tasks complete as they're saved in-memory so long as the process remains running. We don't need these cookies so just ignore them.
Collaborator
Author
|
Relevant issue: #356 I was able to reproduce this with a local wiki farm with similar configurations applied and two different accounts using v2c. Blocking cookies didn't break V2C for me and it resolved the authentication error. |
Collaborator
|
Nice! Not an easy issue to troubleshoot I guess. |
Collaborator
Author
|
The fix seems to have worked. I restarted 6 failed tasks and they didn't throw the OAuth error. Only 3/6 passed but that's because 2 were manually uploaded via the upload wizard later and 1 has a blacklisted title. I was lucky to come across that ticket by chance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A configuration changed introduced in T417833 results in cookies being saved in our workers. This breaks session isolation since we don't clear cookies when tasks complete as they're saved in-memory so long as the process remains running.
We don't need these cookies so just ignore them.