fix(PM-4085): hide biography section when description is absent#96
Merged
hentrymartin merged 2 commits intodevelopfrom Mar 10, 2026
Merged
fix(PM-4085): hide biography section when description is absent#96hentrymartin merged 2 commits intodevelopfrom
hentrymartin merged 2 commits intodevelopfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| // Biography Section | ||
| const biography = member.description || (basicInfo && basicInfo.shortBio) | ||
| const biography = member.description |
There was a problem hiding this comment.
[correctness]
Removing the fallback to basicInfo.shortBio may lead to an empty biography section if member.description is not present. Ensure this change aligns with the intended behavior and does not unintentionally hide information that should be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Ticket link - https://topcoder.atlassian.net/browse/PM-4085
Note: will merge the PR without a review as its a tiny change.