Skip to content

Header navigation border design - #463

Merged
jhancock532 merged 1 commit into
migration-2026from
fix/header-navigation-border-design
Sep 28, 2026
Merged

jhancock532 merged 1 commit into
migration-2026from
fix/header-navigation-border-design

Conversation

@jhancock532

@jhancock532 jhancock532 commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Makes minor adjustments to the header navigation design.

  • Add missing colour variable for light mode hover state
  • Add missing cursor pointer for switch toggle
  • Swap from left border to pseudoelement for better border radius effect
See screenshots

Light mode

image

Dark mode

image

@jhancock532
jhancock532 changed the base branch from main to migration-2026 September 28, 2026 11:58
@jhancock532
jhancock532 marked this pull request as ready for review September 28, 2026 11:59
@chris-lawton

Copy link
Copy Markdown
Member

Thanks @jhancock532 - this looks good!

One thing I did spot when testing in Forced Colors mode is that we've lost the underline on the top level menu links + the links that appear in the drop downs.

For the primary nav menu items we have the mixin here https://github.com/torchbox/torchbox.com/blob/migration-2026/tbx/static_src/sass/components/navigation/_primary-nav-desktop.scss#L63 but I think text-decoration: none has been added here https://github.com/torchbox/torchbox.com/blob/migration-2026/tbx/static_src/sass/components/navigation/_primary-nav-desktop.scss#L75 which is causing the mixin not to work.

For the items in the dropdowns it looks like we just need to include the mixin for the following classes: primary-nav-dropdown__row-link, primary-nav-dropdown__card-link

If you haven't got time then I can pick this up!

@jhancock532
jhancock532 merged commit 5ab9d75 into migration-2026 Sep 28, 2026
10 checks passed
@jhancock532
jhancock532 deleted the fix/header-navigation-border-design branch September 28, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants