-
Notifications
You must be signed in to change notification settings - Fork 48
New : Pups-Overlay #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hi @Pupariaa, thanks for submitting! |
|
|
you pushed both |
Ah, my mistake! It was a first test; I'll remove it. |
|
I deleted it! Thank you for the feedback, it wasn’t supposed to be there aha |
GabuTheDev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
besides the individual comments, you could minify the deps (excluding tosu's websocket).
I have a vague feeling this overlay may have been coded with the help of AI.
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
| <link rel="stylesheet" href="index.css"> | ||
| <script src="deps/countUp.js"></script> | ||
| <title>EtherealGlass Overlay</title> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
title mismatch
| </div> | ||
|
|
||
| <script> | ||
| window.COUNTER_PATH = 'EtherealGlass by Puparia'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
path mismatch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove any non-official tosu websocket
| container.classList.add(positionClass); | ||
| glassPanel.classList.add(positionClass); | ||
|
|
||
| console.log('Settings loaded:', settings); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove all logs.
| // Load settings | ||
| (async () => { | ||
| try { | ||
| const settingsPath = './settings.json'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use the tosu settings api.
example here:
counters/counters/BTMC-Overlay by Happy_24/index.js
Lines 134 to 136 in 7e83cb7
| socket.sendCommand('getSettings', encodeURI(window.COUNTER_PATH)); | |
| socket.commands((data) => { | |
| try { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This clearly does not belong here.
|
@Pupariaa ping |
Demo: https://youtu.be/tcuxGRcZfzE