Skip to content

Conversation

@Pupariaa
Copy link

@GabuTheDev
Copy link
Member

Hi @Pupariaa, thanks for submitting!
It seems like you've uploaded two overlays in one PR.
Please split the two into different PRs so they can seperately be reviewed.

@Pupariaa
Copy link
Author

Hi @Pupariaa, thanks for submitting! It seems like you've uploaded two overlays in one PR. Please split the two into different PRs so they can seperately be reviewed.
Hi ! I don't know which one it could be, I only have one overlay 🤔

@GabuTheDev
Copy link
Member

GabuTheDev commented Nov 23, 2025

you pushed both EtherealGlass and Pups-Overlay

@Pupariaa
Copy link
Author

vous avez poussé les deux EtherealGlassetPups-Overlay

Ah, my mistake! It was a first test; I'll remove it.

@Pupariaa
Copy link
Author

I deleted it! Thank you for the feedback, it wasn’t supposed to be there aha

@GabuTheDev GabuTheDev self-requested a review November 23, 2025 19:52
Copy link
Member

@GabuTheDev GabuTheDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides the individual comments, you could minify the deps (excluding tosu's websocket).

I have a vague feeling this overlay may have been coded with the help of AI.

<meta name="viewport" content="width=device-width, initial-scale=1.0">
<link rel="stylesheet" href="index.css">
<script src="deps/countUp.js"></script>
<title>EtherealGlass Overlay</title>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

title mismatch

</div>

<script>
window.COUNTER_PATH = 'EtherealGlass by Puparia';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

path mismatch

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove any non-official tosu websocket

container.classList.add(positionClass);
glassPanel.classList.add(positionClass);

console.log('Settings loaded:', settings);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove all logs.

Comment on lines +13 to +16
// Load settings
(async () => {
try {
const settingsPath = './settings.json';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use the tosu settings api.
example here:

socket.sendCommand('getSettings', encodeURI(window.COUNTER_PATH));
socket.commands((data) => {
try {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This clearly does not belong here.

@GabuTheDev
Copy link
Member

@Pupariaa ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants