Repository navigation
Resume Firecracker filesystem resize on same-size retry - #563
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StoppedInstanceat the rootfs resize entry point.Closes #540.
Validation
cargo build --workspacecargo fmt -- --checkcargo clippy --workspace --all-targets --all-features -- -D warningscargo test --workspace -- --test-threads=1(umask 022, privateTMPDIR)cargo deny --workspace checktaplo format --checkprek runon the staged diffbash tests/privileged-disk.shon Linux with e2fsprogs 1.47.0 and passwordless sudobash -nfor both changed shell testsThe full Firecracker VM suite was not run because this host has no
/dev/kvm. The Lima VM suite was not run because this host is Linux. The new Firecracker VM phase is therefore awaiting a real VM gate.Security boundary
The change uses the existing privileged disk helper, which validates managed paths after sudo and passes the opened rootfs descriptor to fsck/resize2fs. It adds no new privileged operation, network access, or secret forwarding. The resize entry point now requires the backend's stopped-instance lock witness.