Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #141 +/- ##
===========================================
- Coverage 87.85% 60.75% -27.11%
===========================================
Files 48 52 +4
Lines 2199 4079 +1880
===========================================
+ Hits 1932 2478 +546
- Misses 267 1601 +1334
Continue to review full report at Codecov.
|
Collaborator
|
that does look really nice! I'd be happy to start using this, but would require a bit of work upfront to convert everything |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@martinjrobins just playing around with {fmt}. Not suggesting we should use it, but wanted an excuse to have a go with it.
It seems very nice! And you can put
{}injections inside raw string literals which is very nice for writing svg elements that otherwise need escaped"characters. Has nice clean float precision options, too.The
fmt::formatmatchesstd::formatthat was introduced in C++20.