fix: send review to terminal respects repo default agent setting - #17
Merged
Conversation
Ziinc
force-pushed
the
claude/review-terminal-agent-default-qth3jc
branch
from
July 10, 2026 03:02
9044c6e to
e444558
Compare
Ziinc
force-pushed
the
claude/review-terminal-agent-default-qth3jc
branch
from
July 26, 2026 10:51
e444558 to
344047b
Compare
Contributor
📸 App QA screenshotsRe-ran the flow whose spec this PR adds or modifies — 2 captures. Other specs in the library were not run. send-review-to-terminal-default-agent
Each bullet under a capture is what the spec claims that image should show — open the PNG and check it. commit |
Ziinc
force-pushed
the
claude/review-terminal-agent-default-qth3jc
branch
from
July 27, 2026 19:55
3cb4500 to
1461ca8
Compare
handleCreateAgentWithReview in ShowWorkspace was calling onSessionCreated without an agent field, so the session always launched with the claude agent regardless of the repo or app default_agent setting. Now it reads the repo-level default_agent first (falling back to the app-level default), and passes the resolved agent to onSessionCreated, matching the same resolution logic used when creating sessions from the task input. Also adds getRepoSetting to the api mock in ShowWorkspace test files to avoid falling through to the real implementation when the review handler is invoked in tests. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EA8qrRVMGszi1yK9gnjXKW
Adds a screenshot spec verifying that clicking "Plan" in the Finish Review popover opens a Codex terminal (Sparkles icon) when the repo default_agent is set to "codex", instead of always opening a Claude terminal (Bot icon). Drives the full UI flow: workspace Review tab → add inline comment → Finish Review popover → Plan → terminal pane with codex session. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EA8qrRVMGszi1yK9gnjXKW
…waitFor callbacks
- Each test was calling findByTestId("changes-viewer") without first
clicking the Review tab, so ChangesDiffViewer was never mounted in CI
- Collapsed multi-line waitFor arrow callbacks to satisfy biome format check
…refer-destructuring lint rule
… drop completes synchronously tracing_appender's WorkerGuard only waits a bounded amount of time for the non-blocking writer's background thread to flush on drop. Under CI load that window can be missed even though records were queued, causing an intermittent "expected one JSON line per forwarded record" failure. Poll the file for up to 1s instead of reading it once immediately after the guards drop.
…og line count
The OTel SDK emits its own self-diagnostic record ("Last reference of
LoggerProvider dropped, initiating shutdown.") through the same file
pipeline when SdkLoggerProvider is dropped. Asserting exactly 5 raw lines
made the test fail whenever that diagnostic showed up. Filter to lines
whose body matches our own forwarded records before counting/asserting.
Ziinc
force-pushed
the
claude/review-terminal-agent-default-qth3jc
branch
from
July 29, 2026 12:26
6b40227 to
92bca64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handleCreateAgentWithReview in ShowWorkspace was calling onSessionCreated
without an agent field, so the session always launched with the claude
agent regardless of the repo or app default_agent setting.
Now it reads the repo-level default_agent first (falling back to the
app-level default), and passes the resolved agent to onSessionCreated,
matching the same resolution logic used when creating sessions from the
task input.
Also adds getRepoSetting to the api mock in ShowWorkspace test files to
avoid falling through to the real implementation when the review handler
is invoked in tests.