Add chat to online game#40
Merged
Merged
Conversation
prankware-code
commented
Apr 1, 2026
| class OnlineGameView(PlayableGameViewBase): | ||
| def __init__(self, presenter: OnlineGamePresenter): | ||
| self.presenter = presenter | ||
| self.chat_container = presenter.chat_presenter.view |
Contributor
Author
There was a problem hiding this comment.
Chat is only needed in online play.
Contributor
Author
|
I'll try to fix this later |
Owner
Thanks - and my apologies for the delay and having the workflow blocked. I'll get that setting updated to allow workflows to run without approval. |
Owner
|
After checking out the branch and attempting to start an online game, I get the following error with the changes this brings in: |
Contributor
Author
|
I think we need tests for the new functionality here) |
Contributor
Author
I'll do it later |
prankware-code
force-pushed
the
online-chat
branch
from
3e3e904 to
f4bd330
Compare
Contributor
Author
Done |
Contributor
Author
tests are already in pipelines
|
Contributor
Author
|
@trevorbayless, hi, can u approve it, please? |
Owner
|
Thank you for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With stockfish:
With a random user:
Related to #12