added heartbeat interval to check if query is still fetching data #588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoeyoOgen
suggested changes
Jan 26, 2026
| else: | ||
| self._heartbeat_failures += 1 | ||
| # Stop after 3 consecutive failures | ||
| if self._heartbeat_failures >= 3: |
There was a problem hiding this comment.
You drop heartbeat silently after 3 failures. User has no idea.
Perhaps log a warning?
| break | ||
|
|
||
| # Reset failure count on success | ||
| if status_code == 200: |
There was a problem hiding this comment.
why only 200 and not all 200<=x<300 values?
|
|
||
| ## Progress Callback | ||
|
|
||
| The Trino client supports progress callbacks to track query execution progress in real-time. you can provide a callback function that gets called whenever the query status is updated. |
There was a problem hiding this comment.
Suggested change
| The Trino client supports progress callbacks to track query execution progress in real-time. you can provide a callback function that gets called whenever the query status is updated. | |
| The Trino client supports progress callbacks to track query execution progress in real-time. You can provide a callback that is called whenever the query status is updated. |
| self._result = TrinoResult(self, rows) | ||
|
|
||
| # Start heartbeat if interval is set and next_uri is available | ||
| if self._heartbeat_interval_seconds is not None and self._next_uri is not None: |
There was a problem hiding this comment.
Suggested change
| if self._heartbeat_interval_seconds is not None and self._next_uri is not None: | |
| if self._heartbeat_interval_seconds and self._next_uri: |
isnt this the same?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixed #554
made the python client send heartbeats to the server at fixed configured intervals
Non-technical explanation
queries will now be able to continue fetching data after 15 min
Release notes
( ) This is not user-visible or docs only and no release notes are required.
(X ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: