add new internal worker + worker/temporal validations#129
Open
avimoondra wants to merge 8 commits intomainfrom
Open
add new internal worker + worker/temporal validations#129avimoondra wants to merge 8 commits intomainfrom
avimoondra wants to merge 8 commits intomainfrom
Conversation
avimoondra
commented
Oct 23, 2023
Contributor
Author
There was a problem hiding this comment.
mostly same as
But based on https://github.com/tryretool/retool_development/pull/35620
updating env vars
- name: SERVICE_TYPE
value: INTERNAL_TEMPORAL_WORKER
and ports open on 3015 for health checks. https://github.com/tryretool/retool-helm/blob/main/charts/retool/templates/deployment_workflows_worker.yaml
3e1daf4 to
e4d1452
Compare
avimoondra
commented
Oct 23, 2023
| {{- if not (or (not (.Values.internalWorker.enabled)) (and (.Values.internalWorker.enabled) (or (include "retool.temporal.enabled" .) (include "retool.workflows.enabled" .)))) -}} | ||
| internalWorker: | ||
| Internal worker is enabled (via internalWorker.enabled), but Temporal is not enabled via retool-temporal-services-helm.enabled or workflows.temporal.enabled or via Retool's Managed Temporal for Retool Workflows (via workflows.enabled explicitly, or workflows.enabled implicitly based on image.tag > 3.6.11) | ||
| {{- end -}} |
Contributor
Author
There was a problem hiding this comment.
if internalWorker is NOT enabled - validation ✅
if internalWork is enabled AND (some temporal is enabled OR workflows is enabled, with potential of using retool-managed temporal configured in-app) - validation ✅
roberto-retool
approved these changes
Oct 23, 2023
|
will take this on |
93e6d30 to
0318ae5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
workflows worker on based on version, internal worker off. ✅
workflows worker on version, internalWorker on ✅
workflows worker off based on version, internalWorker on -- validation error! ❌
workflows worker off based on version, internalWorker on + temporal configured ✅