feat: add SameNetTraceCombiningSolver to merge close collinear same-net traces (#34)#277
Open
irisdigitaldocs-maker wants to merge 1 commit intotscircuit:mainfrom
Conversation
…et traces Implements issue tscircuit#34: adds a new pipeline phase that groups schematic traces by globalConnNetId and snaps near-parallel segments onto the same axis coordinate (same Y for horizontal, same X for vertical). Algorithm: - Groups traces by globalConnNetId - Extracts axis-aligned segments from each trace path - Finds pairs where |coord_A - coord_B| <= 0.05 (collinear tolerance) and x/y ranges overlap or gap <= 0.15 units - Snaps the interior segment endpoints of one trace to match the other - Iterates until no more snappable pairs remain /claim tscircuit#34 Co-Authored-By: Paperclip <noreply@paperclip.ing>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements issue #34: adds a new
SameNetTraceCombiningSolverpipeline phase that merges same-net trace lines that are close together./claim #34
How It Works
globalConnNetIdThe solver is inserted into the pipeline after
traceCleanupSolverand before the secondnetLabelPlacementSolverpass, so label placement adapts to the merged trace layout.Testing
bun test tests/solvers/SameNetTraceCombiningSolver/SameNetTraceCombiningSolver.test.ts5 tests covering:
All 36 example tests pass (with updated snapshots for examples 18 and 19 which now show improved merged trace layout).