Skip to content

Fix trace tree root duration - #105

Open
liurenfeng94-ops wants to merge 1 commit into
tsperf:mainfrom
liurenfeng94-ops:fix-root-trace-duration
Open

Fix trace tree root duration#105
liurenfeng94-ops wants to merge 1 commit into
tsperf:mainfrom
liurenfeng94-ops:fix-root-trace-duration

Conversation

@liurenfeng94-ops

Copy link
Copy Markdown

Fixes the root duration computed by toTree.

The code compared event durations while tracking the root duration, but assigned line.ts when it found a larger duration. That mixes timestamp and duration units. This now tracks the latest finite event end timestamp (ts + dur) so the synthetic root duration covers the loaded trace range.

Validation:

  • pnpm vitest run test/trace-duration.test.ts
  • pnpm vitest run
  • pnpm typecheck
  • pnpm exec eslint .
  • pnpm build

@github-actions

Copy link
Copy Markdown

We've flagged this as a potential contribution without a human behind it. We welcome the thoughtful use of AI tools when contributing, but ask all contributors to follow two core principles:

  1. Never let an LLM speak for you - all comments, issues, and PR descriptions should be written in your own words, reflecting your own understanding.
  2. Never let an LLM think for you - only submit contributions you fully understand and can explain.

Please review these AI-assisted contribution guidelines and update this contribution if needed.

If this was flagged in error, we apologise! 😳 Just let us know. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant