fix(app): clear orphan queued compiles after cancel#119
Merged
Conversation
Root cause: cancelled sessions left other queued/running rows holding the global gate; orphan queued rows after n8n trigger failures blocked new runs. Investigation: activity_log showed cancel on session A while session B stayed active; supersedeOrphanQueuedSessions + cancelled-status guard in pipeline. Test: app/src/__tests__/supersede-orphan-queued.test.ts Signed-off-by: tuirk <65666288+tuirk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
queuedcompile sessions when starting a new onboarding finalize (orphans left after failed n8n triggers no longer block the global gate).cancelled→running./api/compile/runon already-cancelled rows; review UI names the blockingactive_session_idon 409.Root cause
Cancelling one session only flips that
session_idtocancelled. A different session stillqueuedorrunningholds the single-compile gate — common aftern8n_unreachableorphans or starting a new run right after cancel.Test plan
cd app && npm test -- src/__tests__/supersede-orphan-queued.test.ts(3/3)