feat: Allow axum extractor in tuono handlers #764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aig787
commented
May 5, 2025
crates/tuono_lib/Cargo.toml
Outdated
| ssr_rs = "0.8.2" | ||
| axum = {version = "0.8.1", features = ["json", "ws"]} | ||
| axum-extra = {version = "0.10.0", features = ["cookie"]} | ||
| axum = { version = "0.8.1", features = ["json", "ws", "form"] } |
|
|
||
| #[derive(Deserialize)] | ||
| struct Payload { | ||
| pub struct Payload { |
| #modified_request | ||
|
|
||
| #fn_name(req.clone(), #argument_names).await | ||
| pub async fn #api_fn_name(#arguments)#return_type { |
Member
There was a problem hiding this comment.
Couldn't we just rename the function?
Contributor
Author
There was a problem hiding this comment.
I'm not sure I follow
| let index = i - 1; | ||
| let argument_name = *pat_type.pat.clone(); | ||
| argument_names.insert(index, argument_name.clone()); | ||
| match &*pat_type.pat { |
Member
There was a problem hiding this comment.
Given the complexity of the approach, I think a good situation for adding tests
Member
|
Hey @aig787, sorry for the late reply. I cannot allocate too much time on this project right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Related issue
Fixes #761
Overview
Removes
tuono_lib::Requestin favor of usingaxum::extract::Requestdirectly. This allows handler methods to specify arbitrary extractors as parameters.