azurestore: Support servecontent - #1381
Open
quality-leftovers wants to merge 16 commits into
Open
Conversation
…more headers and Range without rangeEnd
…nses [StatusRequestedRangeNotSatisfiable, StatusPreconditionFailed, StatusNotFound] and support StatusNotModified response for conditional requests. Respond with 200 OK instead of 204 NoContent for empty blob azurestore: Update ServeContent. Update ServeContent to support conditional requests, range requests. Relevant headers, including some azure specific will be passed on to clients. For empty blobs the response changes from 204 No Content to 200 OK. This is consistent with `http.ServeFile` and azure blob API behavior. Currently this is not consistent across all stores, since GCS does not support empty blob and S3 returns 204 (however S3 API itself should return 200 OK for empty objects).
quality-leftovers
marked this pull request as ready for review
June 24, 2026 12:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #1234
Behavioral changes
TestDownload. I'm unsure on whether this is ok.