Skip to content

Move ReferencedClassFinder to base #1987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Move ReferencedClassFinder to base #1987

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions ...tter/scalding/ReferencedClassFinder.scala → ...tter/scalding/ReferencedClassFinder.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package com.twitter.scalding

import com.twitter.scalding.typed.CoGroupable
import com.twitter.scalding.typed.{TypedPipe, Input, Output, CoGroupable, KeyedList}
import org.slf4j.LoggerFactory
import scala.reflect.runtime.universe
import scala.reflect.runtime.universe.{NullaryMethodType, RuntimeMirror, Symbol, Type, TypeRef}
Expand All @@ -13,19 +13,12 @@ object ReferencedClassFinder {
private val baseContainers = List(
classOf[Execution[_]],
classOf[TypedPipe[_]],
classOf[TypedSink[_]],
classOf[TypedSource[_]],
classOf[Input[_]],
classOf[Output[_]],
classOf[CoGroupable[_, _]],
classOf[KeyedList[_, _]]
)

/**
* Add the given type, as well as all referenced types to the cascading tokens list. note, for maximal
* efficiency, you should also register those types with the kryo instantiator being used.
*/
def addCascadingTokensFrom(c: Class[_], config: Config): Config =
CascadingTokenUpdater.update(config, findReferencedClasses(c) + c)

/**
* Reflect over a scalding job to try and identify types it uses so they can be tokenized by cascading.
* Since scala reflection is broken with the Hadoop InterfaceAudiance annotation (see
Expand All @@ -35,15 +28,22 @@ object ReferencedClassFinder {
*
* Note: this not guaranteed to find every used type. Eg, it can't find types used in a step that isn't
* referred to in a field
*
* This by default only traverses fields of outerClass which are TypedPipe or Executions
*/
def findReferencedClasses(outerClass: Class[_]): Set[Class[_]] = {
def findReferencedClasses(outerClass: Class[_]): Set[Class[_]] =
findReferencedClassesWhere(outerClass) { cls =>
baseContainers.exists(_.isAssignableFrom(cls))
}

def findReferencedClassesWhere(outerClass: Class[_])(fieldFilter: Class[_] => Boolean): Set[Class[_]] = {
val scalaPackage = Package.getPackage("scala")
val mirror = universe.runtimeMirror(outerClass.getClassLoader)
getClassType(outerClass, mirror) match {
case Some(scalaType) =>
(for {
field <- outerClass.getDeclaredFields
if baseContainers.exists(_.isAssignableFrom(field.getType))
if fieldFilter(field.getType)
scalaSignature <- getFieldType(outerClass, scalaType, field).toSeq
clazz <- getClassesForType(mirror, scalaSignature)
/* The scala root package contains a lot of shady stuff, eg compile-time wrappers (scala.Int/Array etc),
Expand Down