Skip to content

Add clone impls to some errors#238

Closed
cameron1024 wants to merge 2 commits into
txpipe:mainfrom
cameron1024:clone-more-errors
Closed

Add clone impls to some errors#238
cameron1024 wants to merge 2 commits into
txpipe:mainfrom
cameron1024:clone-more-errors

Conversation

@cameron1024
Copy link
Copy Markdown
Contributor

Very small PR that adds Clone impls to a couple of error types. I have some error types in my own crate that have Clone bounds, and IMO it's better for the underlying error to implement Clone, rather than chucking it in an Arc.

Thanks 😁

@scarmuega
Copy link
Copy Markdown
Member

Hi @cameron1024 — thanks for the contribution, and apologies for the very long delay in getting back to you.

Since this PR was opened, the repository has been restructured: pallas-miniprotocols and pallas-multiplexer no longer exist (their functionality was folded into pallas-network), so this patch can no longer be rebased as-is. The error types it targeted have been reorganized as well.

If you still need Clone on the current network/error types, we'd be happy to look at a fresh PR against main. Closing this one for housekeeping — thanks again for taking the time.

@scarmuega scarmuega closed this May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants