Fix blank thumbnail for Animal Island theme#498
Open
YanyingWei1997 wants to merge 2 commits into
Open
Conversation
Gallery index.html loads thumbnails from /media/thumbnails/<thumbnail>, but the thumbnail was committed to /thumbnails/ in PR typora#492, so the gallery card rendered blank. Move it to the correct directory.
Superseded by /media/thumbnails/animal-island-thumbnail.png.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Animal Island theme (added in #492) shows a blank thumbnail in the gallery.
Root cause
index.htmlloads gallery thumbnails from:But in #492 the thumbnail was committed to
/thumbnails/animal-island-thumbnail.png(missing themedia/prefix), so the gallery requests/media/thumbnails/animal-island-thumbnail.pngwhich 404s → blank card.Fix
media/thumbnails/animal-island-thumbnail.png(same 250×200 image)thumbnails/animal-island-thumbnail.pngNo change to the post front matter —
thumbnail: animal-island-thumbnail.pngwas already correct; only the file location was wrong.