Skip to content

fix: use correct arg name in z.assert.length.neq - #59

Closed
RafDevX wants to merge 2 commits into
typst-community:mainfrom
RafDevX:fix-length-neq
Closed

RafDevX wants to merge 2 commits into
typst-community:mainfrom
RafDevX:fix-length-neq

Conversation

@RafDevX

@RafDevX RafDevX commented Jun 25, 2026

Copy link
Copy Markdown

Trying to use assert.length.neq currently fails because rhs does not exist; this PR fixes that

@tingerrr

Copy link
Copy Markdown
Member

Could you add a test that checks that this actually resolves the issue? Just using the assertion should suffice I think.

@RafDevX

RafDevX commented Jun 26, 2026 •

Copy link
Copy Markdown
Author

Ok, I've added a test. I'm not sure how to generate a corresponding ref/1.png, so perhaps you can do that yourself if you would like to have it too? I've enabled "Allow edits by maintainers" for this PR

@tingerrr

Copy link
Copy Markdown
Member

Ok, I've added a test. I'm not sure how to generate a corresponding ref/1.png, so perhaps you can do that yourself if you would like to have it too? I've enabled "Allow edits by maintainers" for this PR

Unfortunately I don't really have time to prepare the tooling for this. The original test references were created with typst-test, but that version is quite old and doesn't have release artifacts. You could try installing tytanic 0.2.0-rc1.

I suggest creating the test freshly with tt add assertions/length or tt new assertions/length to ensure it has references, overwrite the generates test.typ file with your new test and run tt update to update the reference.

I'm unsure if that will work exactly the same, I don't remember when the typst-test -> tytanic rename happened anymore.

@jamesrswift

Copy link
Copy Markdown
Member

Closed as merged in a different PR because I absolutely suck at git. Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants