chore(test): remove dead @tag :polling annotations#39
Open
pinetops wants to merge 1 commit into
Open
Conversation
The :polling tag was only ever read by SlowTestGuard (deleted in #37) and is referenced by no exclude filter, mix alias, or config. With the guard gone the tag is inert — 37 occurrences across 15 integration test files, removed. No behaviour change; the event-driven-await detector now governs these tests instead. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
pinetops
force-pushed
the
chore/remove-dead-polling-tags
branch
from
2a661a4 to
2c61048
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes 37
@tag :pollingannotations across 15 integration test files.Why
The
:pollingtag was only ever consumed bySlowTestGuard, which was deleted in #37 (replaced by the event-driven-await regression detector). With the guard gone, the tag is inert:exclude/includefilter inintegration_test/cases/test_helper.exsreferences it (excludes arepending,live_view_only,cdp_only,bidi_unstable, etc.).mixalias passes--only/--exclude polling.So the tags do nothing — they're leftover noise that reads as if it still controls something. Removing them.
Verification
@tag :pollinglines (none combined with other tags), so each was removed cleanly above itstest.mix format --check-formattedpasses; lib compiles.slow_event_test,trigger_action_test) → 2 tests, 0 failures, and the await detector did not fire (they pass on events, not timeouts) — confirming the tests run correctly without the tag.No behaviour change. The event-driven-await detector now governs these tests.
🤖 Generated with Claude Code