Skip to content

refactor: hoist StatusMessage out of PrintToZebraDialog render #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
u8array merged 1 commit into from
May 5, 2026
Merged

refactor: hoist StatusMessage out of PrintToZebraDialog render #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/components/Output/PrintToZebraDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,15 @@ const LS_PRINTER_UID = "zebra_print_uid";
type Tab = "network" | "browserprint";
interface Status { type: "idle" | "sending" | "success" | "error"; message?: string }

function StatusMessage({ status }: { status: Status }) {
if (status.type === "idle" || status.type === "sending") return null;
return (
<p className={`font-mono text-[10px] ${status.type === "success" ? "text-green-400" : "text-red-400"}`}>
{status.message}
</p>
);
}
Comment on lines +19 to +26
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The StatusMessage component should handle cases where status.message might be missing or empty to avoid rendering an empty <p> tag. In a flex container with a gap, an empty child still occupies space and creates an unnecessary layout gap. Additionally, adding role="status" improves accessibility by ensuring status updates are announced to screen readers.

function StatusMessage({ status }: { status: Status }) {
  if (status.type === "idle" || status.type === "sending" || !status.message) return null;
  return (
    <p
      role="status"
      className={`font-mono text-[10px] ${status.type === "success" ? "text-green-400" : "text-red-400"}`}
    >
      {status.message}
    </p>
  );
}


interface Props {
zpl: string;
onClose: () => void;
Expand Down Expand Up @@ -97,15 +106,6 @@ export function PrintToZebraDialog({ zpl, onClose }: Props) {
: "text-muted hover:text-text"
}`;

function StatusMessage({ status }: { status: Status }) {
if (status.type === "idle" || status.type === "sending") return null;
return (
<p className={`font-mono text-[10px] ${status.type === "success" ? "text-green-400" : "text-red-400"}`}>
{status.message}
</p>
);
}

return (
<div
className="fixed inset-0 z-50 flex items-center justify-center bg-black/50"
Expand Down