Update Aztec barcode ZPL generation#22
Merged
Merged
Conversation
Modify the `toZPL` function for Aztec barcodes to correctly include the error correction level (`ecLevel`) in the ZPL command. Previously, a fixed `N` was used for this parameter, which is incorrect. This change also updates the corresponding test fixtures to reflect the correct ZPL generation.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Aztec barcode ZPL generation in src/registry/aztec.tsx to utilize the ecLevel property for the errorControl parameter, replacing previously hardcoded values. Test fixtures in fixtures.json and testCases.ts were updated to align with this change. Feedback suggests enhancing the documentation within the code to detail the valid ranges for the errorControl parameter according to the ZPL II specification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify the
toZPLfunction for Aztec barcodes to correctly include the error correction level (ecLevel) in the ZPL command. Previously, a fixedNwas used for this parameter, which is incorrect.This change also updates the corresponding test fixtures to reflect the correct ZPL generation.