feat(ui): show Labelary privacy notice on first Print, not just Preview#33
Merged
Conversation
Print routed through Labelary was previously hidden until the user had acknowledged the notice via Preview. Surface Print whenever the gate is enabled and open the notice on first click instead, matching the Preview flow. Disclaimer is extracted into a shared LabelaryNoticeModal so wording stays in lockstep, locale body now mentions both features, and a new env test pins the build-time gate behavior.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the Labelary privacy notice into a shared LabelaryNoticeModal component, ensuring consistent disclosure before using preview or print features. It also updates localization files to reflect that both features utilize the external service and adds environment-based testing for the Labelary gate. Feedback focuses on improving the accessibility of the new modal by adding appropriate ARIA roles, labels, and IDs.
LabelaryNoticeModal and LabelPreviewModal now expose role=dialog, aria-modal and aria-labelledby so screen readers announce them as modal dialogs. The icon-only close buttons get a localized aria-label via a new app.close translation across all 32 locales.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Print routed through Labelary was previously hidden until the user had acknowledged the notice via Preview. Surface Print whenever the gate is enabled and open the notice on first click instead, matching the Preview flow. Disclaimer is extracted into a shared LabelaryNoticeModal so wording stays in lockstep, locale body now mentions both features, and a new env test pins the build-time gate behavior.