Skip to content

docs(readme): add light/dark screenshot pair via picture element #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
u8array merged 1 commit into from
May 9, 2026
Merged

docs(readme): add light/dark screenshot pair via picture element #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,11 @@ Writing ZPL by hand is tedious: cryptic commands, dot coordinates, no visual fee

---

<!-- TODO: add screenshot -->
<picture>
<source media="(prefers-color-scheme: dark)" srcset="docs/screenshot-dark.png">
<source media="(prefers-color-scheme: light)" srcset="docs/screenshot-light.png">
<img alt="Zebra Print Lab — designer with a sample label" src="docs/screenshot-light.png">
</picture>
Comment on lines +17 to +21
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The <picture> block can be optimized by removing the redundant light-scheme <source> tag, as the <img> element already serves as the default fallback for the light theme. Additionally, the alt text should be more descriptive to improve accessibility, incorporating details about the interface and the sample label shown to provide better context for screen reader users.

Improvement opportunities:

  • Redundancy: The <source media="(prefers-color-scheme: light)" ...> tag is unnecessary when the <img> tag points to the same file.
  • Accessibility: A more descriptive alt attribute helps users understand the visual context of the application (e.g., mentioning the designer interface and the barcode).
Suggested change
<picture>
<source media="(prefers-color-scheme: dark)" srcset="docs/screenshot-dark.png">
<source media="(prefers-color-scheme: light)" srcset="docs/screenshot-light.png">
<img alt="Zebra Print Lab — designer with a sample label" src="docs/screenshot-light.png">
</picture>
<picture>
<source media="(prefers-color-scheme: dark)" srcset="docs/screenshot-dark.png">
<img alt="Zebra Print Lab designer interface showing a sample label with a Code 128 barcode and the properties panel" src="docs/screenshot-light.png">
</picture>


---

Expand Down
Binary file added docs/screenshot-dark.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added docs/screenshot-light.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.