Feat/alt click cycle select#46
Merged
Merged
Conversation
Inverted shapes let users see objects layered behind them, but normal click-to-select can only reach the topmost object at a point. Alt+click now cycles through the stack: first click selects the topmost hit, each subsequent Alt+click at (approximately) the same pointer position dives one layer deeper, wrapping at the bottom. Implemented with a native capture-phase mousedown listener on the canvas container. Konva's getAllIntersections drives the hit-graph (handles view rotation, pan offset, per-shape transforms transparently). A pure nextCycleIndex helper holds the cycle state machine for unit testing.
Adds a hint in the Edit-properties section explaining the use case (reaching objects hidden behind a filled or inverted shape) and a row in the shortcut table for discoverability.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request implements an Alt+click "select-below" feature, allowing users to cycle selection through stacked objects on the canvas. The changes include a new useAltClickCycle hook, a logic helper with unit tests, and updated documentation in the README. Review feedback identifies opportunities to optimize the hook by deferring the creation of the object ID set until intersections are confirmed and suggests removing a redundant null check for the next selected ID.
…uard Reviewer-spotted (gemini-code-assist on PR #46): - Build the objIds lookup only after we know intersections is non-empty, so empty-canvas Alt+clicks skip the per-object map allocation. - Add a comment on the `if (!nextId) return` guard noting that it is required by noUncheckedIndexedAccess even though the index is logically guaranteed valid.
The app already accepts both metaKey and ctrlKey (useGlobalShortcuts), but the README documented only Ctrl-bindings, which is misleading for Mac users. Inline `Ctrl/⌘` (and `Alt/⌥` for the new alt+click row) keeps each shortcut self-contained without splitting the table.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.