You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
adopt_accepted_socket calls were already passing IP along to the open handler.
I have tested these in JS and it seems to work. Do you see anything missing?
Changes summary:
uSockets: add the IP to the pre_open handler.
uWS: pass the IP to the pre_open handler.
uWS: update adoptSocket() to accept an optional IP parameter and pass it to uSockets.
uWS: update LocalCluster and addChildApp() to retrieve the IP on pre_open and pass it to adoptSocket().
uWS.js: update adoptSocket() to accept an optional IP parameter.
If someone accepts external FD, needs the IP on the request and uses the UWS_REMOTE_ADDRESS_USERSPACE cache, they have to pass the IP to adoptSocket().
If someone accepts external FD, needs the IP on the request and uses the UWS_REMOTE_ADDRESS_USERSPACE cache, they have to pass the IP to adoptSocket().
That's okay they can get it from the FD before they pass it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to uWS.js issue 1257.
Allows the IP to be exported in addition to the FD.