Add UWS_REMOTE_ADDRESS_USERSPACE macro for userspace remote address caching#1917
Merged
uNetworkingAB merged 4 commits intomasterfrom Mar 16, 2026
Merged
Add UWS_REMOTE_ADDRESS_USERSPACE macro for userspace remote address caching#1917uNetworkingAB merged 4 commits intomasterfrom
uNetworkingAB merged 4 commits intomasterfrom
Conversation
…per-socket data Co-authored-by: uNetworkingAB <110806833+uNetworkingAB@users.noreply.github.com>
Co-authored-by: uNetworkingAB <110806833+uNetworkingAB@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add compiler macro check for remote address caching
Add UWS_REMOTE_ADDRESS_USERSPACE macro for userspace remote address caching
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
UWS_REMOTE_ADDRESS_USERSPACEis defined, the remote IP is cached in per-socket data at connection time (from theon_openarguments) rather than retrieved via syscall on eachgetRemoteAddress()call.Changes
AsyncSocketData— addschar remoteAddress[16]andint remoteAddressLengthfields, guarded by#ifdef UWS_REMOTE_ADDRESS_USERSPACEHttpContexton_open— copiesip/ip_lengthinto the socket ext immediately after placement-new; validates0 < ip_length <= 16, sets length to0otherwiseAsyncSocket::getRemoteAddress()— returns astring_viewinto the cached socket data under the macro; falls back tous_socket_remote_address()when undefined✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.