WIP: [SRU Exception] Add nVidia DOCA-OFED DKMS packaging#564
WIP: [SRU Exception] Add nVidia DOCA-OFED DKMS packaging#564Alessio-Faina wants to merge 12 commits into
Conversation
ogandojose
left a comment
There was a problem hiding this comment.
Generally good. Please correct the NVIDIA capitalization everywhere.
basak
left a comment
There was a problem hiding this comment.
Please update the text to clarify:
- What SRU policy points for which you are requesting an exception.
- Details of the testing you will perform to the standard specified at https://documentation.ubuntu.com/project/SRU/reference/requirements/#test-plan
- How we can be confident that these updates will not regress users, for example by referencing upstream commitments to maintain use cases available in Ubuntu stable releases
- How we can be confident that an update won't drop support for hardware previously supported in a specific Ubuntu release, for example by referencing upstream commitments to not drop hardware support in the updates that you propose to land into Ubuntu the future
|
Hi @basak , thanks for your review. I'll work on the points you raised, in particular I'll need some time for the second one. I will ask you a new review once all the required points will be properly defined in the document. |
251f134 to
af43ec2
Compare
|
Hi @basak , I added the information you required to my best, please let me know if you think this is enough to you, or if you need more. |
|
Sorry, I've read your proposal a few times and I don't think it meets my expectations. It's not clear to me what class of updates you're proposing should be acceptable and what class will not. Overall the text seems excessively verbose with much of the content not relevant from the perspective of the SRU process. Please keep it concise and focus only on how you are fulfilling documented SRU requirements. If there are specific exceptions you are requesting, please refer specifically to that and make it clear what you want to deviate from and why. Maybe it would be best to get an experienced Ubuntu core dev to take a look at this please and make sure they sign off as it being ready before you ask for it to be considered by the SRU team. |
889bb82 to
39ba034
Compare
MitchellAugustin
left a comment
There was a problem hiding this comment.
I left a few suggestions inline
|
@MitchellAugustin @ogandojose @tjaalton Any more suggestions? |
b4e3806 to
1a25e0b
Compare
MitchellAugustin
left a comment
There was a problem hiding this comment.
@Alessio-Faina Looks good to me now
Signed-off-by: Alessio Faina <alessio.faina@canonical.com>
Signed-off-by: Alessio Faina <alessio.faina@canonical.com>
Signed-off-by: Alessio Faina <alessio.faina@canonical.com>
Signed-off-by: Alessio Faina <alessio.faina@canonical.com>
Signed-off-by: Alessio Faina <alessio.faina@canonical.com>
Signed-off-by: Alessio Faina <alessio.faina@canonical.com>
Signed-off-by: Alessio Faina <alessio.faina@canonical.com>
Signed-off-by: Alessio Faina <alessio.faina@canonical.com>
Signed-off-by: Alessio Faina <alessio.faina@canonical.com>
Signed-off-by: Alessio Faina <alessio.faina@canonical.com>
Signed-off-by: Alessio Faina <alessio.faina@canonical.com>
f9aa6f3 to
4e85a65
Compare
Description
This document is added to introduce an SRU exception for the nVidia DOCA-OFED DKMS Kernel modules.
It details what will be produced, packaged and how it will be tested.
Checklist