Make HasTLController generic to MultiIOModules#18
Open
harrisonliew wants to merge 1 commit into
Open
Conversation
jwright6323
requested changes
Feb 13, 2020
| case _ => x.clock match { | ||
| case OuterClock => (this.clock, this.reset.toBool) | ||
| case _ => ??? | ||
| } |
Collaborator
There was a problem hiding this comment.
IMO, if we're genericizing this, these probably need to change (Your random analog widget might have a different set of clocks)
| case _ => x.clock match { | ||
| case OuterClock => (this.clock, this.reset.toBool) | ||
| case _ => ??? | ||
| } |
| with HasTLController | ||
| with HasTLController { | ||
| override def allios = Seq(ssio, encoderio, decoderio, packetizerio) ++ debugio | ||
| } |
Collaborator
There was a problem hiding this comment.
Hmm, I don't really like this. It's easy to mess up and requires a lot of boilerplate. An alternative might be to create a GenericHasTLController module, then make the current HasTLController implementation inherit from it so that this "API" doesn't change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
HasTLControllertrait is super useful to other analog widgets, so let's make it generic toMultiIOModules and check its type in the case of aLane. Requires overridingalliosas well.Will need to revive #9 eventually to make everything "awl".