Skip to content

Conversation

@harriet-fisher
Copy link
Contributor

To address issue #1514

Model Updates:

  • Added profile_visibility field (Public/Friends Only/Private)
  • Added friend_request_permission field (Everyone/Friends of Friends/Nobody)
  • Added searchable_by_strangers boolean field

Forms:

  • Created PrivacySettingsForm for managing/setting/updating privacy settings

Views:

  • Updated user_profile_detail_view to check privacy settings and pass can_send_friend_request context
  • Handles friending limitations (i.e. not accepting friend requests from non-mutuals) by hiding add friend button
  • Updated user_search_results to respect privacy settings
  • Added privacy_settings_view for managing settings

Template:

  • Created templates/users/privacy_settings.html for settings management
  • Updated userprofile_detail.html to conditionally show "Add Friend" button (see above)
  • Added "Privacy Settings" button to user's own profile

urls:
Added route for privacy settings page

…iend invitations and appearance in user search.
Copy link
Contributor

@davdma davdma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Harriet! I appreciate these myriad of features. Having a settings page even if it's just limited to privacy controls for now can be super useful for future developers who want to flush it out even further.

Copy link
Contributor

@jonathanbacon22 jonathanbacon22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you Harriet

that don't need a profile on the website (e.g., API-only users)
"""

VISIBILITY_CHOICES = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great addition!

@@ -0,0 +1,55 @@
{% extends "base.html" %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

[Users] Improve User Profile Privacy Settings

4 participants