[Interactive fiction] Minor bug fixes #1581
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 27, 2025 22:04
gkharrell01
changed the title
gkharrell01
commented
May 28, 2025
src/chigame/games/urls.py
Outdated
| path("lobby/<int:pk>/code/", views.MatchCodeView.as_view(), name="match-code"), | ||
| # interactive fiction | ||
| path("interactive-fiction/", views.IFGameCreateView.as_view(), name="interactive-fiction-create"), | ||
| path('upload/<int:pk>/', views.UploadFileView.as_view(), name='upload-file'), |
Contributor
Author
There was a problem hiding this comment.
URL path was removed at some point...
gkharrell01
commented
May 28, 2025
| const author = document.getElementById('id_author').value.trim(); | ||
| const desc = document.getElementById('id_description').value.trim(); | ||
| const gameFile = document.getElementById('id_game_file'); | ||
| const gameFile = document.getElementById('myFile'); |
Contributor
Author
There was a problem hiding this comment.
A few variable names in the modal logic were repeated which caused bugs.
gkharrell01
commented
May 28, 2025
| </div> | ||
| </div> | ||
| </h3> | ||
| </form> |
Contributor
Author
There was a problem hiding this comment.
Main problem: Image submission created two forms in the file, which caused no data to passed when POST request was made.
smagdalen
approved these changes
May 28, 2025
| path("lobby/<int:pk>/code/", views.MatchCodeView.as_view(), name="match-code"), | ||
| # interactive fiction | ||
| path("interactive-fiction/", views.IFGameCreateView.as_view(), name="interactive-fiction-create"), | ||
| path("upload/<int:pk>/", views.UploadFileView.as_view(), name="upload-file"), |
| data-maxlength>{{ form.content_warning.value }}</textarea> | ||
| </div> | ||
| <div> | ||
| <label for="id_image">Cover Imags</label> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal: Fix minor bugs before final presentation. A few variable name issues and url deletions that caused issue with submission and redirection. Added comments in files changed to give context.