fix: replace useSyncExternalStore with explicit ssr prop #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ydration mismatches
The Router component used useSyncExternalStore with a serverSnapshotSymbol
sentinel to handle the SSR/hydration boundary, which still caused React
hydration mismatch warnings. Replace it with a simpler useState + useEffect
approach controlled by an explicit `ssr` prop:
- ssr={false} (default): initialize locationEntry from adapter.getSnapshot()
- ssr={true}: start with null locationEntry, sync after hydration via useEffect
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
useSyncExternalStore+serverSnapshotSymbolsentinel with a simpleruseState+useEffectapproach inRouter.tsxssrprop toRouterProps— whentrue, the router starts withnulllocationEntry and syncs after hydration; whenfalse(default), it initializes fromadapter.getSnapshot()immediatelysetLocationEntry(adapter.getSnapshot())in the mount effect is a no-op for non-SSR because adapters cache snapshots by referential identityTest plan
pnpm build— builds successfullypnpm typecheck— no type errorspnpm test:run— all 174 tests pass (no test changes needed sincessrdefaults tofalse)pnpm format— code style compliant🤖 Generated with Claude Code