-
-
Notifications
You must be signed in to change notification settings - Fork 20
feat(uview-pro): main.ts 添加 uview-pro 组件库的导入和使用 #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughAdds a new default-exported function to inject a uview-pro UI framework entry into existing data structures, conditionally inserting it alongside vue entries using array transformation logic. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Suggested labels
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/core/template/UI/uview-pro/src/main.js.data.mjs (1)
1-13: Logic correctly injects uview-pro after vue; consider a small robustness/readability tweakThe behavior looks correct and matches the PR goal: when a
vueentry exists, you append auview-proentry right after it while preserving everything else.If you want to make this a bit more robust and explicit, you could:
- Guard against a missing
entriesfield.- Always return arrays from the
flatMapcallback so the intent is clearer.For example:
export default function getData({ oldData }) { const uViewProEntries = { id: 'uview-pro', importer: 'import uViewPro from \'uview-pro\'', use: 'app.use(uViewPro)', } return { ...oldData, - entries: oldData.entries.flatMap(entry => - entry.id === 'vue' ? [entry, uViewProEntries] : entry, - ), + entries: (oldData.entries ?? []).flatMap(entry => + entry.id === 'vue' ? [entry, uViewProEntries] : [entry], + ), } }Purely optional, but it makes the data flow a bit more defensive and easier to read.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/core/template/UI/uview-pro/src/main.js.data.mjs(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: test (-t vitesse, 20.x, windows-latest)
- GitHub Check: test (-t vitesse, 20.x, macos-latest)
- GitHub Check: build (20.x, windows-latest)
- GitHub Check: stable - i686-pc-windows-msvc - node@20
- GitHub Check: stable - x86_64-pc-windows-msvc - node@20
- GitHub Check: stable - aarch64-pc-windows-msvc - node@20
- GitHub Check: stable - aarch64-apple-darwin - node@20
|
疑惑在 |
可以测一下 |
|
@FliPPeDround 呼叫大佬,没有问题麻烦给合一下吧,影响使用了 |
应该不会影响,我刚刚看了下他的组册函数,只有主题设置没有组册组件 |
好的,最近有点忙,我没有测试,你确保可用就行 |
Ok,我本地测了,没问题,等你发完版我再测一下。感谢! |
Description 描述
选择使用 uView Pro 组件库时,需要在 main.ts 添加 uview-pro 组件库的导入和使用,否则造成组件库使用问题
Linked Issues 关联的 Issues
Additional context 额外上下文
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.