Fix OptionVarULE in zerovec to also use C, packed#5143
Merged
Conversation
robertbastian
requested changes
Jun 27, 2024
Member
robertbastian
left a comment
robertbastian
left a comment
There was a problem hiding this comment.
On main there are 14 #[repr(packed)]s in utils/zerovec. This changes 3
Member
|
17 |
Manishearth
force-pushed
the
zerovec-packed
branch
from
a40dfe2 to
3140401
Compare
Manishearth
force-pushed
the
zerovec-packed
branch
from
3140401 to
eda9180
Compare
Member
Author
|
Ah, forgot to hit save on the design doc |
robertbastian
approved these changes
Jun 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We overlooked this
Backport in #5144