Skip to content

Conversation

@roozbehp
Copy link
Contributor

@roozbehp roozbehp commented Nov 13, 2025

@roozbehp
Copy link
Contributor Author

roozbehp commented Nov 13, 2025

Sorry, this is a little hard to review, but be assured that I triple-checked it myself very thoroughly. confusablesSummary.txt is relatively easier to check compared to other files, but it's still pretty long.

Anyways, please take a look.

@roozbehp roozbehp marked this pull request as draft November 13, 2025 05:45
@roozbehp
Copy link
Contributor Author

Converting to draft to fix Java style issues.

@roozbehp roozbehp marked this pull request as ready for review November 13, 2025 06:21
@roozbehp
Copy link
Contributor Author

Java style fixed. Ready for review.

Copy link
Collaborator

@josh-hadley josh-hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roozbehp, apologies for taking a long time to get this reviewed. It was tricky as advertised, but all looks good. The process did make me want to see if a one-time revamp of confusables-source.txt to force most or all entries to our new preferred format universally would be worthwhile (presumably making reviews/maintenance like this a little less taxing).

@macchiati
Copy link
Member

Note that we need to add confusable changes to the Migration section of each release. That is, if the skeleton(X) changes from Y to Z, that requires implementations that have mappings to skeletons need to update.

(We had some breakages of indexes in production softward with the U17 integrations; luckily caught by unittests.)

@roozbehp
Copy link
Contributor Author

Note that we need to add confusable changes to the Migration section of each release. That is, if the skeleton(X) changes from Y to Z, that requires implementations that have mappings to skeletons need to update.

We're going to have a lot of confusable changes in Unicode 18.0, but this specific pull request should not affect the skeleton of any string, since a conformant implementation would not use any of the data removed in this pull request: They simply don't occur in NFD form that the algorithm applies before looking for the prototypes.

@roozbehp roozbehp merged commit bcd1dec into main Nov 25, 2025
24 of 27 checks passed
@roozbehp roozbehp deleted the roozbehp-non-nfd branch November 25, 2025 02:34
@macchiati
Copy link
Member

macchiati commented Nov 25, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants