Skip to content

Conversation

@eggrobin
Copy link
Member

@eggrobin eggrobin requested a review from markusicu November 17, 2025 14:56
if (ch <= 0x2B81D) {
return CJK_D_BASE;
}
if (ch <= 0x2B81E && rCompositeVersion >= 0x120000) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand rCompositeVersion. Otherwise LGTM.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the major version number in bits 23..16 (18=0x12), minor in 15..8, "milli" in 7..0.
Computing a single number makes range checks trivial compared with lexical comparison of multiple fields.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course that number looked much more readable until Unicode 10…

@eggrobin eggrobin merged commit 0de54c8 into unicode-org:main Nov 17, 2025
28 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants