refactor: rename CLI to Cli and add proper error handling#24
Merged
Conversation
- Rename Unitsdb::CLI to Unitsdb::Cli (proper Ruby naming) - Add new error classes: CLIRuntimeError, InvalidParameterError, FileNotFoundError, ValidationError, InvalidFormatError - Replace all exit(1) calls with proper exception raising - Add --trace option as Thor class_option for debugging - Add error handling at each Thor command level to display clean error messages without backtraces - Update specs to expect new error classes instead of SystemExit
ronaldtse
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unitsdb::CLItoUnitsdb::Cli(proper Ruby naming conventions)CLIRuntimeError(base class)InvalidParameterError- for invalid CLI argumentsFileNotFoundError- for missing files/directoriesValidationError- for validation failuresInvalidFormatError- for invalid format optionsexit(1)calls with proper exception raising--traceThor option for showing full backtraces during debuggingTest plan
--traceflag shows full backtrace when needed