Skip to content

chore: allow for swift-syntax of 603.0.0#150

Merged
bok- merged 2 commits intounsignedapps:mainfrom
Brett-Best:chore/swift-syntax-603.0.0-support
Apr 8, 2026
Merged

chore: allow for swift-syntax of 603.0.0#150
bok- merged 2 commits intounsignedapps:mainfrom
Brett-Best:chore/swift-syntax-603.0.0-support

Conversation

@Brett-Best
Copy link
Copy Markdown
Contributor

@Brett-Best Brett-Best commented Apr 7, 2026

📒 Description

Allows for Swift Syntax to resolve to 603.0.0.

🔍 Detailed Design

I fixed a deprecation warning and ensured compilation with Swift Syntax 600.0.0 still worked.

📓 Documentation Plan

N/A

🗳 Test Plan

Running the tests of the SwiftPM package it has against the My Mac target.

🧯 Source Impact

N/A

✅ Checklist

  • I've added at least one test that validates that my change is working, if appropriate
  • I've followed the code style of the rest of the project
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary

Copilot AI review requested due to automatic review settings April 7, 2026 11:15
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the SwiftPM dependency constraint for swift-syntax to include 603.0.0, and adjusts the macro conformance to match the updated MemberMacro expansion signature required by newer SwiftSyntax releases.

Changes:

  • Widen swift-syntax dependency range to allow resolving 603.x (by moving the upper bound to < 604.0.0).
  • Update FlagContainerMacro’s MemberMacro.expansion signature to include the conformingTo parameter (addressing the deprecation / API shift in SwiftSyntax).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
Sources/VexilMacros/FlagContainerMacro.swift Updates MemberMacro expansion signature to include conformingTo protocols, aligning with newer SwiftSyntax macro APIs.
Package.swift Expands the allowed swift-syntax version range to include 603.0.0.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Brett-Best
Copy link
Copy Markdown
Contributor Author

@bok- if you could approve the workflows please, I'm fairly confident they should pass 🙏🏻

Copy link
Copy Markdown
Contributor

@bok- bok- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Brett-Best! Looks good, lets get this in and I'll cut beta 2.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 8, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@bok- bok- merged commit c50af49 into unsignedapps:main Apr 8, 2026
37 checks passed
@Brett-Best Brett-Best deleted the chore/swift-syntax-603.0.0-support branch April 8, 2026 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants