This repository was archived by the owner on Jan 27, 2025. It is now read-only.
feature: Filter improvements#183
Open
tmarcinkowski-logitech wants to merge 5 commits intouptick:masterfrom
Open
feature: Filter improvements#183tmarcinkowski-logitech wants to merge 5 commits intouptick:masterfrom
tmarcinkowski-logitech wants to merge 5 commits intouptick:masterfrom
Conversation
dreadera
suggested changes
Jun 17, 2021
Contributor
dreadera
left a comment
There was a problem hiding this comment.
Thank you for the contribution :)
My only feedback is that the naming convention for files is kebab-case
So instead of defaultLogic.js It should be default-logic.js
Contributor
Author
|
Great! I fixed the filename and added one more additional commit so please take a look at the whole again :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changelog
How Has This Been Tested?
Checklist: