Repository navigation
test: use silo for s3 integration tests - #40
Merged
Merged
Conversation
quay.io/minio/minio and quay.io/minio/mc now require authentication (401 on manifest HEAD), which fails the test/prepare and validate-dockerfile jobs and thereby skips the whole linux test matrix. Port of moby/buildkit 4509d3a. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
ajwerner
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
quay.io/minio/minioandquay.io/minio/mcstarted requiring authentication (every manifest request now returns401 UNAUTHORIZED, including for the pinnedRELEASE.2025-09-07T16-13-09Z/RELEASE.2025-08-13T08-35-41Ztags). SinceDockerfilepulls both as build stages,test / prepareand thevalidate-dockerfilejob forDockerfilefail, and becausetest / rundepends onprepare, the entire Linux integration test matrix has been silently skipped on every branch — master's scheduled runs have failed the same way since 09-25 (e.g. https://github.com/useblacksmith/buildkit/actions/runs/36407431457), and the two red checks on #39 are this.Upstream hit the same break and moved the S3 test fixture to
pgsty/silo(a MinIO fork shipping both the server andmcli) in moby/buildkit@4509d3a. This is a straight port of that commit onto our fork:util/testutil/helpers/minio.gojust renamesminioBin→siloBin = "silo"; silo keeps theserver --json --addressCLI and theMINIO_ROOT_USER/MINIO_ROOT_PASSWORDenv, soNewMinioServerand the s3 cache tests are otherwise unchanged. Test-only change, no effect on shipped binaries.Checks:
gofmt,go build ./util/testutil/...,go vet ./util/testutil/helpers. The real verification is CI on this PR (test / prepare+ the Linuxtest / runmatrix coming back).Link to Devin session: https://app.devin.ai/sessions/58d4432cc29646cda20732dd71045579
Open in Devin Desktop: https://app.devin.ai/desktop/session/58d4432cc29646cda20732dd71045579?variant=devin
Requested by: @piob-io
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.