Skip to content

test: use silo for s3 integration tests - #40

Merged
piob-io merged 1 commit into
masterfrom
devin/1790704777-silo-s3-tests
Sep 30, 2026
Merged

piob-io merged 1 commit into
masterfrom
devin/1790704777-silo-s3-tests

Conversation

@piob-io

@piob-io piob-io commented Sep 29, 2026 •

Copy link
Copy Markdown

Summary

quay.io/minio/minio and quay.io/minio/mc started requiring authentication (every manifest request now returns 401 UNAUTHORIZED, including for the pinned RELEASE.2025-09-07T16-13-09Z / RELEASE.2025-08-13T08-35-41Z tags). Since Dockerfile pulls both as build stages, test / prepare and the validate-dockerfile job for Dockerfile fail, and because test / run depends on prepare, the entire Linux integration test matrix has been silently skipped on every branch — master's scheduled runs have failed the same way since 09-25 (e.g. https://github.com/useblacksmith/buildkit/actions/runs/36407431457), and the two red checks on #39 are this.

Upstream hit the same break and moved the S3 test fixture to pgsty/silo (a MinIO fork shipping both the server and mcli) in moby/buildkit@4509d3a. This is a straight port of that commit onto our fork:

-ARG MINIO_VERSION=RELEASE.2025-09-07T16-13-09Z
-ARG MINIO_MC_VERSION=RELEASE.2025-08-13T08-35-41Z
+ARG SILO_VERSION=RELEASE.2026-09-03T13-18-01Z
-FROM quay.io/minio/minio:${MINIO_VERSION} AS minio
-FROM quay.io/minio/mc:${MINIO_MC_VERSION} AS minio-mc
+FROM pgsty/silo:${SILO_VERSION} AS silo
-COPY --link --from=minio /usr/bin/minio /usr/bin/
-COPY --link --from=minio-mc /usr/bin/mc /usr/bin/
+COPY --link --from=silo /usr/bin/silo /usr/bin/
+COPY --link --from=silo /usr/bin/mcli /usr/bin/mc

util/testutil/helpers/minio.go just renames minioBin → siloBin = "silo"; silo keeps the server --json --address CLI and the MINIO_ROOT_USER/MINIO_ROOT_PASSWORD env, so NewMinioServer and the s3 cache tests are otherwise unchanged. Test-only change, no effect on shipped binaries.

Checks: gofmt, go build ./util/testutil/..., go vet ./util/testutil/helpers. The real verification is CI on this PR (test / prepare + the Linux test / run matrix coming back).

Link to Devin session: https://app.devin.ai/sessions/58d4432cc29646cda20732dd71045579
Open in Devin Desktop: https://app.devin.ai/desktop/session/58d4432cc29646cda20732dd71045579?variant=devin
Requested by: @piob-io


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

quay.io/minio/minio and quay.io/minio/mc now require authentication
(401 on manifest HEAD), which fails the test/prepare and
validate-dockerfile jobs and thereby skips the whole linux test matrix.
Port of moby/buildkit 4509d3a.

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@devin-ai-integration

Copy link
Copy Markdown

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@piob-io
piob-io merged commit 12c66da into master Sep 30, 2026
194 of 195 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants