Repository navigation
vendor: update grpc to v1.83.2 and go directive to 1.26 - #42
Merged
Merged
Conversation
…1.26 Co-authored-by: Codesmith Staging <codesmith-bot@users.noreply.github.com>
|
This PR is too large for Bugbot to review. It changes 65,835 lines and 3,767,017 characters. Split the change into smaller pull requests to get a review. |
Co-authored-by: Codesmith Staging <codesmith-bot@users.noreply.github.com>
Co-authored-by: Codesmith Staging <codesmith-bot@users.noreply.github.com>
Co-authored-by: Codesmith Staging <codesmith-bot@users.noreply.github.com>
….26 vet Co-authored-by: Codesmith Staging <codesmith-bot@users.noreply.github.com>
piob-io
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears two Aikido findings on
go.modso the default-branch rescan stops reporting them:google.golang.org/grpcv1.79.3 -> v1.83.2 (latest v1.83.x patch).go 1.25.5->go 1.26.0.go getpulled grpc's minimum requirements along with it:go.opentelemetry.io/otel(+metric,sdk,sdk/metric,trace) v1.40.0 -> v1.44.0,golang.org/x/{crypto,mod,net,sync,sys,term,text}andgoogle.golang.org/genproto/googleapis/{api,rpc}to their newer releases.go mod tidyandgo mod vendorwere run with Go 1.26, sovendor/andvendor/modules.txtmatch (thevalidate-vendorbake target runs the same commands).No other Go pins needed changing:
Dockerfile,hack/dockerfiles/*.Dockerfile,frontend/dockerfile/cmd/dockerfile-frontend/Dockerfile, and theGO_VERSIONenv inbuildkit.yml,frontend.yml, andtest-os.ymlare already on 1.26. This PR does not touchDockerfile, so it does not overlap with #38 (SEC-701).After merge, a new
v0.29.x-blacksmithtag is needed for the shipped buildkitd binaries to include the fix.Promotion risk: Medium. The toolchain does not change: v0.29.6-blacksmith is already built with go1.26.8 from
golang:1.26-alpine. But this buildkitd runs inside every customer Docker build that uses setup-docker-builder, and it picks up four grpc minor versions on the server side plus three Go 1.26 GODEBUG default flips.:authoritynorHostget HTTP 400 (1.83.2). Thego 1.26.0directive flips the binary'sDefaultGODEBUGfromcryptocustomrand=1,tlssecpmlkem=0,urlstrictcolons=0to the Go 1.26 defaults. otel moves 1.40 -> 1.44 andx/netmoves 0.51 -> 0.58. The autofix commits are refactors with identical behavior:new(expr)replaces pointer helpers, and the HEALTHCHECK history string is checked byte-identical to the old%qoutput.urlstrictcolons=1: a registry, mirror, or proxy URL with a bare colon in the host (http://host:1:2, unbracketed IPv6) now fails to parse. Pull/push fails with a URL parse error.tlssecpmlkem=1: two more post-quantum groups are advertised in the TLS ClientHello. A broken registry or proxy middlebox could time out the handshake. Escape hatch:GODEBUG=tlssecpmlkem=0.GRPC_GO_EXPERIMENTAL_CONTROL_BUFFER_THROTTLE_LIMIT.buildctl, gateway frontends) always send:authority, so the 400 rejection should not hit them.buildkitdandbuildctlfrom e5f8e16.govulncheckreports no grpc advisories,tidy+vendorproduce no changes, and a Dockerfile build with a RUN step succeeded over gRPC. That was one small local build. It did not cover a Blacksmith VM, sticky disk, setup-docker-builder, registry TLS or push, concurrency, GC/prune, or graceful shutdown. Repo CI (unit, integration, validate) had not finished on the current head when this was written. Earlier heads only failed Go 1.26 lint/vet, which the autofix commits fix.v0.29.7-blacksmithis tagged and published, FastActions/fa bumps its pin (agent/Makefile,MODULE.bazel,BUILD.bazel), and an agent release reaches runner hosts throughproduction.ini. From then on, every customer job using setup-docker-builder / build-push-action is affected. Roll out to[canary]first. To roll back, re-roll hosts to the previous agent tag, or revert the fa pin tov0.29.6-blacksmith; the buildkit repo needs nothing. After rollout, watch setup-docker-builder failures (buildkitd process has crashed, SIGKILL after graceful shutdown, sticky disk commit errors), registry TLS/handshake and URL parse errors in build logs, buildkitd memory per job, and Docker build duration.Need help on this PR? Tag
@codesmith-botwith what you need.The rebuilt buildkitd moves from Go 1.25.5 / grpc v1.79.3 to Go 1.26.0 / grpc v1.83.2, and govulncheck no longer flags any grpc advisory, GHSA-hrxh-6v49-42gf included.
Merge-base
This PR
e5f8e16cAlso checked · 2 more claims, all matched observations
Proof on
e5f8e16cNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is enabled. (Staging)