Skip to content

chore: remove simulate_old_pagination test helper and its test #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sachiniyer merged 1 commit into from
Sep 10, 2026
Merged

chore: remove simulate_old_pagination test helper and its test #338

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 0 additions & 30 deletions src/commands/bugs.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1397,19 +1397,6 @@ mod tests {
all.iter().skip(off).take(lim).cloned().collect()
}

/// Simulate the *old* `fetch_page_multi_status` approach: shared offset
/// per status, then concatenate and truncate.
fn simulate_old_pagination(per_status: &[&[Bug]], page: u32, limit: u32) -> Vec<Bug> {
let offset = page_to_offset(page, limit);
let mut combined = Vec::new();
for bugs in per_status {
combined.extend(simulate_api(bugs, limit, offset));
}
let lim = usize::try_from(limit).unwrap_or(usize::MAX);
combined.truncate(lim);
combined
}

/// Simulate the *new* `fetch_page_multi_status` approach: each status
/// fetched from offset 0 up to `offset + limit`, then drain + truncate
/// on the combined list.
Expand Down Expand Up @@ -1444,23 +1431,6 @@ mod tests {
ids
}

#[test]
fn old_pagination_drops_resolved_bugs_issue_300() {
// Issue scenario: 50 pending + 40 resolved, limit=50.
// The old approach drops all 40 resolved bugs.
let pending = make_bugs("pending", 50);
let resolved = make_bugs("resolved", 40);
let per_status: Vec<&[Bug]> = vec![&pending, &resolved];

let all_ids = collect_all_ids(&per_status, 50, simulate_old_pagination);
// Old approach only finds the 50 pending bugs; the 40 resolved are lost.
assert_eq!(all_ids.len(), 50, "old approach should only find 50 of 90");
assert!(
!all_ids.iter().any(|id| id.starts_with("bug_resolved")),
"old approach should miss all resolved bugs"
);
}

#[test]
fn new_pagination_returns_all_bugs_issue_300() {
// Same scenario: 50 pending + 40 resolved, limit=50.
Expand Down
Loading