Dev/fss unit tests - #48
Open
Nav2607 wants to merge 3 commits into
Open
Conversation
wlodaralex
reviewed
Jun 23, 2026
| assert output["beta_deg"] == pytest.approx(0.0, abs = 0.5) | ||
|
|
||
| def test_eclipse_vector(mock_fss): | ||
| sun_vector = np.array([0.0, 0.0, 0.0]) |
Collaborator
There was a problem hiding this comment.
This isn't a realistic way for this case to arise. Throughout the simulation, we will always have a valid vector to the Sun being calculated and it's a question of whether any portion of the Earth is also along that vector. Using [0, 0, 0] is kind of a cheat.
wlodaralex
reviewed
Jun 23, 2026
| def test_sun_vector_fov(mock_fss): | ||
| sun_vector = np.array([1.0, 0.0, 1.0]) | ||
|
|
||
| output = mock_fss._angle_computation(sun_vector) |
Collaborator
There was a problem hiding this comment.
We should be hitting the measure() function since that's the public version that will get called by the sim.
wlodaralex
requested changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issue #21
Important
Blocked by #55
This PR is dependent on the eclipse refactor in PR #55.