Stty: Implemented input and output baud rate setting for stty #9517

ChrisDryden · 2025-11-28T22:20:42Z

This PR is the final GNU test fix for stty. This test overrides cfsetispeed and checks to see if it is called. Currently our implementation of stty only overrides the cfsetospeed. The support to do both in GNU existed for a while. I changed the enum and parser to treat the ispeed and ospeed separately and I added integration tests that compare that using those new flags matches the input and output of the GNU implementation.

github-actions · 2025-11-28T22:35:24Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

github-actions · 2025-11-29T04:55:28Z

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)

github-actions · 2025-12-02T16:13:02Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

ChrisDryden · 2025-12-02T16:30:18Z

Hmm an issue with one of the baud rate integration tests came up, was covered up by the seq failure before

ChrisDryden · 2025-12-03T05:01:20Z

Darn so it used to be back before 9.2 that it would except invalid arguments without failing?

github-actions · 2025-12-03T05:12:05Z

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

codspeed-hq · 2025-12-03T05:20:45Z

Merging this PR will improve performance by 3.2%

Summary

⚡ 1 improved benchmark
✅ 139 untouched benchmarks
⏩ 37 skipped benchmarks¹

Performance Changes

	Benchmark	`BASE`	`HEAD`	Efficiency
⚡	`tsort_input_parsing_heavy[5000]`	73.7 ms	71.5 ms	+3.2%

_{Comparing ChrisDryden:stty_input_and_output_speed (dc7ee6a) with main (20a5c3a)}

37 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

github-actions · 2025-12-07T18:56:23Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

github-actions · 2025-12-07T19:33:21Z

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

github-actions · 2025-12-07T21:55:25Z

GNU testsuite comparison:

Congrats! The gnu test tests/stty/bad-speed is now passing!

github-actions · 2025-12-17T16:47:44Z

GNU testsuite comparison:

Congrats! The gnu test tests/stty/bad-speed is now passing!

github-actions · 2025-12-24T14:07:21Z

GNU testsuite comparison:

Congrats! The gnu test tests/stty/bad-speed is now passing!

ChrisDryden · 2025-12-30T19:25:58Z

util/build-gnu.sh

 # * the test says "maybe we should not fail when no context available"
 "${SED}" -i -e "s|returns_ 1||g" tests/cp/no-ctx.sh
+
+# Skip bad-speed test if not interactive (requires controlling terminal)


I think this might be not required once this PR is merged? #9881

coreutils/coreutils#160 turns out that it didn't fix the issue and upon further testing it appears to be an issue in the gnu tests themselves.

src/uu/stty/src/stty.rs

github-actions · 2025-12-30T20:21:00Z

GNU testsuite comparison:

GNU test failed: tests/tty/tty-eof. tests/tty/tty-eof is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/stty/bad-speed is now passing!

github-actions · 2025-12-30T20:51:27Z

GNU testsuite comparison:

Congrats! The gnu test tests/stty/bad-speed is now passing!

ChrisDryden · 2026-01-06T17:20:54Z

@sylvestre mind if I get a review on this one after the stty hotfix? Stty is doing so much better than back in November 🥳

on different platforms the output is different due to different versions so cannot use this as a test.

…issing that flag

ChrisDryden · 2026-01-07T16:10:45Z

I was able to remove the GNU test patch now that the upstream test was fixed in gnu coreutils and #10077 was merged

ChrisDryden mentioned this pull request Nov 28, 2025

stty: High Level GNU Testsuite Issue Tracker #9338

Open

ChrisDryden force-pushed the stty_input_and_output_speed branch 2 times, most recently from 5097f92 to a1c0044 Compare November 29, 2025 04:40

This was referenced Nov 29, 2025

stty: Changing shell command to add recognizing a TTY for stty tests #9336

Merged

GNU coreutils 9.9: Test report #9127

Open

ChrisDryden force-pushed the stty_input_and_output_speed branch from a1c0044 to 5a54163 Compare December 2, 2025 15:57

ChrisDryden marked this pull request as draft December 2, 2025 16:30

ChrisDryden force-pushed the stty_input_and_output_speed branch from 5a54163 to 2903ff7 Compare December 3, 2025 04:56

ChrisDryden mentioned this pull request Dec 3, 2025

Different versions of GNU coreutils on different platforms in integration tests #9547

Open

ChrisDryden mentioned this pull request Dec 5, 2025

stty: Updating coreutils version on x86 musl ci hosts for stty tests #9570

Closed

ChrisDryden marked this pull request as ready for review December 7, 2025 19:24

ChrisDryden force-pushed the stty_input_and_output_speed branch from 1f6ede8 to d018ba7 Compare December 7, 2025 21:38

ChrisDryden force-pushed the stty_input_and_output_speed branch from d018ba7 to 970fef3 Compare December 17, 2025 16:02

ChrisDryden mentioned this pull request Dec 19, 2025

GNU coreutils 9.9: Detailed Test report 12/19 #9729

Open

ChrisDryden force-pushed the stty_input_and_output_speed branch from 970fef3 to 31d86dc Compare December 24, 2025 13:29

ChrisDryden mentioned this pull request Dec 27, 2025

stty: invalid argument #8608

Closed

ChrisDryden commented Dec 30, 2025

View reviewed changes

sylvestre reviewed Dec 30, 2025

View reviewed changes

src/uu/stty/src/stty.rs Outdated Show resolved Hide resolved

ChrisDryden force-pushed the stty_input_and_output_speed branch 2 times, most recently from de449bf to f015317 Compare December 30, 2025 20:06

ChrisDryden mentioned this pull request Jan 5, 2026

stty: Add bad-speed.sh test script to fetch-gnu.sh #10077

Merged

ChrisDryden added 7 commits January 7, 2026 11:09

Implemented input and output baud rate setting for stty

a445f5c

Ignore test_ispeed_ospeed_valid_speeds for issue uutils#9547

2ad441c

on different platforms the output is different due to different versions so cannot use this as a test.

Re-enable ignored tests for valid and invalid speeds

58d50fe

Adding require_controlling_input_terminal_ for bad-speed test since m…

3eb5b2a

…issing that flag

Refactor apply_baud_rate_flag to remove duplicate cfg blocks

2d1b991

Add PartialEq derive for BaudType in test builds

7f4091f

Remove skip condition for bad-speed test now that upstream is updated

dc7ee6a

ChrisDryden force-pushed the stty_input_and_output_speed branch from 3e44d90 to dc7ee6a Compare January 7, 2026 16:09

Uh oh!

Stty: Implemented input and output baud rate setting for stty #9517

Are you sure you want to change the base?

Stty: Implemented input and output baud rate setting for stty #9517

Uh oh!

Conversation

ChrisDryden commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 28, 2025

Uh oh!

github-actions bot commented Nov 29, 2025

Uh oh!

github-actions bot commented Dec 2, 2025

Uh oh!

ChrisDryden commented Dec 2, 2025

Uh oh!

ChrisDryden commented Dec 3, 2025

Uh oh!

github-actions bot commented Dec 3, 2025

Uh oh!

codspeed-hq bot commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will improve performance by 3.2%

Summary

Performance Changes

Footnotes

Uh oh!

github-actions bot commented Dec 7, 2025

Uh oh!

github-actions bot commented Dec 7, 2025

Uh oh!

github-actions bot commented Dec 7, 2025

Uh oh!

github-actions bot commented Dec 17, 2025

Uh oh!

github-actions bot commented Dec 24, 2025

Uh oh!

ChrisDryden Dec 30, 2025

Choose a reason for hiding this comment

Uh oh!

ChrisDryden Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Dec 30, 2025

Uh oh!

github-actions bot commented Dec 30, 2025

Uh oh!

ChrisDryden commented Jan 6, 2026

Uh oh!

ChrisDryden commented Jan 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ChrisDryden commented Nov 28, 2025 •

edited

Loading

codspeed-hq bot commented Dec 3, 2025 •

edited

Loading