Skip to content

Conversation

@oech3
Copy link
Contributor

@oech3 oech3 commented Dec 5, 2025

  1. Simplify symlinks
  2. Reduce time to build by multicall
  3. Minor cleanup
  4. Build few utils for SELinux tests. About 5 min saved.

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

GNU testsuite comparison:

GNU test failed: tests/chcon/chcon-fail. tests/chcon/chcon-fail is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/install/basic-1. tests/install/basic-1 is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/install/create-leading. tests/install/create-leading is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/install/d-slashdot. tests/install/d-slashdot is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/install/install-C. tests/install/install-C is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/install/install-C-root. tests/install/install-C-root is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/install/strip-program. tests/install/strip-program is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/ln/misc. tests/ln/misc is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/misc/invalid-opt. tests/misc/invalid-opt is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/misc/usage_vs_getopt (fails in this run but passes in the 'main' branch)
Note: The gnu test tests/misc/xattr is now being skipped but was previously passing.

@oech3 oech3 force-pushed the patch-3 branch 2 times, most recently from 37abe86 to a9a99e3 Compare December 5, 2025 12:34
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 5, 2025

CodSpeed Performance Report

Merging #9567 will not alter performance

Comparing oech3:patch-3 (c1d79e1) with main (2d718f2)

Summary

✅ 127 untouched
⏩ 6 skipped1

Footnotes

  1. 6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

GNU testsuite comparison:

GNU test failed: tests/chcon/chcon-fail. tests/chcon/chcon-fail is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/install/basic-1. tests/install/basic-1 is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/install/create-leading. tests/install/create-leading is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/install/d-slashdot. tests/install/d-slashdot is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/install/install-C. tests/install/install-C is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/install/install-C-root. tests/install/install-C-root is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/install/strip-program. tests/install/strip-program is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/ln/misc. tests/ln/misc is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/misc/invalid-opt. tests/misc/invalid-opt is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/misc/usage_vs_getopt (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/misc/xattr is now being skipped but was previously passing.

@oech3 oech3 marked this pull request as draft December 5, 2025 14:00
@oech3 oech3 force-pushed the patch-3 branch 4 times, most recently from e7841c6 to 0b68da7 Compare December 5, 2025 19:56
@github-actions
Copy link

github-actions bot commented Dec 5, 2025

GNU testsuite comparison:

GNU test failed: tests/chcon/chcon-fail. tests/chcon/chcon-fail is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/install/basic-1. tests/install/basic-1 is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/install/create-leading. tests/install/create-leading is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/install/d-slashdot. tests/install/d-slashdot is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/install/install-C. tests/install/install-C is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/install/install-C-root. tests/install/install-C-root is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/install/strip-program. tests/install/strip-program is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/ln/misc. tests/ln/misc is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/misc/invalid-opt. tests/misc/invalid-opt is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/misc/usage_vs_getopt (fails in this run but passes in the 'main' branch)
Note: The gnu test tests/misc/xattr is now being skipped but was previously passing.

@oech3 oech3 changed the title build-gnu.sh: Refactor e.g. reusing symlink logic build-gnu.sh: Refactor e.g. symlink logic Dec 5, 2025
@oech3 oech3 force-pushed the patch-3 branch 4 times, most recently from 4f5d830 to 608c5ac Compare December 5, 2025 20:47
@github-actions
Copy link

github-actions bot commented Dec 5, 2025

GNU testsuite comparison:

GNU test failed: tests/id/context. tests/id/context is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/id/no-context. tests/id/no-context is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/install/basic-1. tests/install/basic-1 is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/install/create-leading. tests/install/create-leading is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/install/d-slashdot. tests/install/d-slashdot is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/install/install-C. tests/install/install-C is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/install/install-C-root. tests/install/install-C-root is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/install/install-C-selinux. tests/install/install-C-selinux is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/install/install-Z-selinux. tests/install/install-Z-selinux is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/install/strip-program. tests/install/strip-program is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/ln/misc. tests/ln/misc is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/misc/invalid-opt. tests/misc/invalid-opt is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/mkdir/restorecon. tests/mkdir/restorecon is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/mkdir/selinux. tests/mkdir/selinux is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/misc/usage_vs_getopt (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/chcon/chcon is now being skipped but was previously passing.
Note: The gnu test tests/cp/no-ctx is now being skipped but was previously passing.
Note: The gnu test tests/ls/selinux is now being skipped but was previously passing.
Note: The gnu test tests/misc/selinux is now being skipped but was previously passing.
Note: The gnu test tests/misc/xattr is now being skipped but was previously passing.

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

GNU testsuite comparison:

GNU test failed: tests/id/context. tests/id/context is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/id/no-context. tests/id/no-context is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/install/basic-1. tests/install/basic-1 is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/install/create-leading. tests/install/create-leading is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/install/d-slashdot. tests/install/d-slashdot is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/install/install-C. tests/install/install-C is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/install/install-C-root. tests/install/install-C-root is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/install/install-C-selinux. tests/install/install-C-selinux is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/install/install-Z-selinux. tests/install/install-Z-selinux is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/install/strip-program. tests/install/strip-program is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/ln/misc. tests/ln/misc is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/misc/invalid-opt. tests/misc/invalid-opt is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/mkdir/restorecon. tests/mkdir/restorecon is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/mkdir/selinux. tests/mkdir/selinux is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/misc/usage_vs_getopt (fails in this run but passes in the 'main' branch)
Note: The gnu test tests/chcon/chcon is now being skipped but was previously passing.
Note: The gnu test tests/cp/no-ctx is now being skipped but was previously passing.
Note: The gnu test tests/ls/selinux is now being skipped but was previously passing.
Note: The gnu test tests/misc/selinux is now being skipped but was previously passing.
Note: The gnu test tests/misc/xattr is now being skipped but was previously passing.

@oech3 oech3 changed the title build-gnu.sh: Refactor e.g. symlink logic build-gnu.sh: Refactor symlinking & use multicall for faster build Dec 5, 2025
@github-actions
Copy link

github-actions bot commented Dec 5, 2025

GNU testsuite comparison:

GNU test failed: tests/id/context. tests/id/context is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/id/no-context. tests/id/no-context is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/mkdir/restorecon. tests/mkdir/restorecon is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/mkdir/selinux. tests/mkdir/selinux is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/chcon/chcon is now being skipped but was previously passing.
Note: The gnu test tests/cp/no-ctx is now being skipped but was previously passing.
Note: The gnu test tests/ls/selinux is now being skipped but was previously passing.
Note: The gnu test tests/misc/selinux is now being skipped but was previously passing.

@github-actions
Copy link

github-actions bot commented Dec 6, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

@oech3 oech3 marked this pull request as ready for review December 6, 2025 06:03
@oech3 oech3 changed the title build-gnu.sh: Refactor symlinking & use multicall for faster build build-gnu.sh: Refactor symlinking & use MULTICALL=y for faster build Dec 6, 2025
@oech3
Copy link
Contributor Author

oech3 commented Dec 27, 2025

This looks multicall-seq specific issue. Also I can't see the difference between individual seq on Arch Linux.

@oech3 oech3 force-pushed the patch-3 branch 7 times, most recently from 1335fc7 to 442b2f0 Compare December 27, 2025 16:06
@oech3 oech3 marked this pull request as ready for review December 27, 2025 16:17
@oech3
Copy link
Contributor Author

oech3 commented Dec 27, 2025

@cakebaker @sylvestre Ready.
No idea about multicall specific seq bug... So I made it individual.

@oech3 oech3 force-pushed the patch-3 branch 3 times, most recently from 3a3d48b to 501b467 Compare December 28, 2025 10:15
@oech3

This comment was marked as resolved.

@oech3 oech3 force-pushed the patch-3 branch 5 times, most recently from 280bac5 to ea774bc Compare December 28, 2025 12:25
@github-actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/tail/assert is no longer failing!

@oech3
Copy link
Contributor Author

oech3 commented Dec 28, 2025

I was confised by nproc things. But this PR is ready now.

@github-actions
Copy link

GNU testsuite comparison:

Note: The gnu test tests/id/smack was skipped on 'main' but is now failing.
Note: The gnu test tests/mkdir/smack-no-root was skipped on 'main' but is now failing.
Note: The gnu test tests/mkdir/smack-root was skipped on 'main' but is now failing.

@oech3
Copy link
Contributor Author

oech3 commented Dec 29, 2025

@sylvestre Would you merge this now? Rebasing every PR without reducing build time is bit pain.

@sylvestre sylvestre merged commit 650fe9f into uutils:main Dec 29, 2025
72 checks passed
@oech3 oech3 deleted the patch-3 branch December 29, 2025 15:49
@oech3
Copy link
Contributor Author

oech3 commented Dec 29, 2025

Thankyou!

naoNao89 pushed a commit to naoNao89/coreutils that referenced this pull request Dec 31, 2025
build-gnu.sh: Use MULTICALL=y and skip not used utils for faster build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants