refactor(cp): replace println! with write_stdout_line for robust error #9901
+117
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r handling Introduce a new `write_stdout_line` function that locks stdout and returns a Result to handle write failures gracefully. Replace all `println!` calls in verbose output, debug messages, and path printing with this function, propagating errors via `CopyResult<()>` instead of panicking on I/O errors. This improves reliability when stdout is closed or encounters issues during cp operations.
|
GNU testsuite comparison: |
…justing exit code - Made `code` mutable to allow modification on flush errors. - Ignore BrokenPipe errors during stdout flush to avoid breaking utilities that silence it (e.g., seq). - Set exit code to 1 if a flush error occurs and the original code was 0, treating write errors as failures.
|
GNU testsuite comparison: |
- Added check to capture if stdout was closed before utility execution using fcntl on Unix. - Modified flush error handling to ignore EBADF errors when stdout was pre-closed, avoiding false failures for silent commands.
Reorder imports for consistency and refactor the ignore_closed_stdout condition to a more concise form, improving code readability without altering functionality.
Add `stdout_is_closed()` and `is_closed_stdout_error()` functions to check if stdout is closed and detect write errors due to closed stdout. Refactor the `bin!` macro to use these functions, reducing code duplication and improving reusability across utilities.
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new
write_stdout_linefunction that locks stdout and returns a Result to handle write failures gracefully. Replace allprintln!calls in verbose output, debug messages, and path printing with this function, propagating errors viaCopyResult<()>instead of panicking on I/O errors. This improves reliability when stdout is closed or encounters issues during cp operations.related
misc/close-stdout.sh