[jayhemnani9910]

--include and --exclude are kept as two separate sets: a file is skipped when any --exclude matches it or no --include does, whatever the order. GNU grep goes by order. Its man page: "If contradictory --include and --exclude options are given, the last matching one wins. If no --include or --exclude options match, a file is included unless the first such option is --include." So mixing them gives different files:

$ ls tree
a.txt  b.log
$ ./target/debug/grep -r -l --exclude='a*' --include='*.txt' foo tree
$ /usr/bin/grep -r -l --exclude='a*' --include='*.txt' foo tree    # GNU grep 3.12
tree/a.txt
tree/b.log

a.txt matches both, and the --include comes last. b.log matches neither, and the first pattern is an --exclude. --exclude=zz --include='*.txt' has the same problem: GNU keeps b.log, and this skips it.

The patterns now go into one list in command-line order (from clap's indices). --exclude-from patterns sit at the position of that option. GlobSet stays for --exclude-dir, and its is_empty goes since nothing uses it anymore.

Tests: recursive_include_exclude_last_match_wins covers both orders above and an --include followed by --exclude-from. It fails on main. The existing include/exclude tests pass unchanged. cargo test: 116 passed (115 on main), clippy and rustfmt clean. I compared 12 include/exclude/exclude-from orderings with GNU grep 3.12 under -r -l, and they all give the same files now.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.

[codspeed]

Merging this PR will not alter performance

✅ 10 untouched benchmarks
⏩ 17 skipped benchmarks¹

---

_{Comparing jayhemnani9910:include-exclude-order (61f6533) with main (01fb6c3)}

Footnotes

1. 17 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.

[jayhemnani9910]

Thanks, went with changing GlobSet. Pushed 61f6533: GlobSet keeps whether each pattern is an include or an exclude, so FileGlobs and its copy of add are gone. --exclude-dir adds its patterns as excludes and skips the same directories as before. Checked --exclude-dir and mixed --include/--exclude against GNU grep 3.12 on a small tree, same output.

[sylvestre]

Thanks for your PR