fix: the external configuration loader fetches v2ray... in external.go#3366
Open
orbisai0security wants to merge 1 commit into
Open
fix: the external configuration loader fetches v2ray... in external.go#3366orbisai0security wants to merge 1 commit into
orbisai0security wants to merge 1 commit into
Conversation
Automated security fix generated by Orbis Security AI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix critical severity security issue in
main/confloader/external/external.go.Vulnerability
V-001main/confloader/external/external.go:40Description: The external configuration loader fetches v2ray's routing and proxy configuration over HTTP using a plain http.Request with no cryptographic integrity verification of the response. The downloaded configuration is applied directly without checking a cryptographic signature, comparing a hash against a known-good value, or enforcing HTTPS with certificate validation. Any attacker who can intercept the HTTP connection (via ARP spoofing, DNS poisoning, BGP hijacking, or a compromised Wi-Fi network) or who compromises the remote configuration server can serve a malicious configuration that immediately takes effect.
Changes
main/confloader/external/external.goVerification
Automated security fix by OrbisAI Security