fix: the external configuration loader fetches confi... in external.go#3367
Open
orbisai0security wants to merge 1 commit intov2ray:masterfrom
Open
fix: the external configuration loader fetches confi... in external.go#3367orbisai0security wants to merge 1 commit intov2ray:masterfrom
orbisai0security wants to merge 1 commit intov2ray:masterfrom
Conversation
Automated security fix generated by Orbis Security AI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix critical severity security issue in
main/confloader/external/external.go.Vulnerability
V-002main/confloader/external/external.go:52Description: The external configuration loader fetches configuration over HTTP using client.Do(&http.Request{...}). v2ray configuration files typically contain highly sensitive data including proxy server addresses, authentication credentials (usernames, passwords, UUIDs), inbound/outbound routing rules, and potentially TLS private keys. When fetched over plain HTTP, the entire configuration payload is transmitted in cleartext and is visible to any passive network observer on the path between the v2ray instance and the configuration server — no active attack is required. This is distinct from V-001 (active MITM tampering) in that it requires only passive observation.
Changes
main/confloader/external/external.goVerification
Automated security fix by OrbisAI Security